[Flight] Add Client Infrastructure #17234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size changes (stable)ReactDOM: size: 🔺+4.8%, gzip: -10.4% Details of bundled changes.Comparing: bdcdb69...141bb4d react-dom
react-noop-renderer
react-flight
|
Size changes (experimental)Details of bundled changes.Comparing: bdcdb69...141bb4d react-dom
react-noop-renderer
react-flight
|
We don't want unit tests but instead test how both server and clients work together. So this merges server/client test files.
sebmarkbage
force-pushed
the
flight
branch
2 times, most recently
from
60157da to
182f6ea
Compare
I'll probably end up deleting these deps later but they're here for now.
gaearon
approved these changes
Nov 1, 2019
| complete(response); | ||
| } | ||
| function error(e: ProgressEvent): void { | ||
| reportGlobalError(response, new TypeError('Network error')); |
There was a problem hiding this comment.
Should there be any protection around this being called more than once? E.g. if some failure events fire in a succession.
There was a problem hiding this comment.
This is supposed to mirror the type of fetch rejecting. Not sure what type that is.
There will be protection against multiple in the internals once we actually have an implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some infra to the client build so that we can parse a stream into an object that can suspend.
See the fixture for example.