Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools standalone shell changes: #17213

Merged
merged 2 commits into from
Oct 31, 2019
Merged

DevTools standalone shell changes: #17213

merged 2 commits into from
Oct 31, 2019

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Oct 29, 2019 •
edited
Loading

Cosmetic changes to the RN shell:

  1. Update React Native wording to mention recent changes to how DevTools and React Native are meant to connect.
  2. Tweak styles slightly.

Waiting to connect

Before

Screen Shot 2019-10-29 at 1 36 30 PM

After

Screen Shot 2019-10-29 at 1 36 51 PM

Error

Before

Screen Shot 2019-10-29 at 1 42 00 PM

After

Screen Shot 2019-10-29 at 1 57 25 PM

DevTools standalone shell changes:
250fa3f 
1. Update React Native connection wording
2. Tweak styles slightly
threepointone
threepointone approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the second screen; would it be a good idea to provide actionable advice? It’s not apparent it’s an error with that styling. Maybe “Please stop the other running instance” or something?

Feel free to disregard, or do in a future PR. It simply stood out to me in this one.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 29, 2019

Hm. I guess we could tweak the wording a bit to say something more like:

Another instance of DevTools is running. Only one copy of DevTools can be used at a time.

@sizebot
Copy link

sizebot commented Oct 29, 2019 •
edited
Loading

Size changes (experimental)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against ef077d4

@sizebot
Copy link

sizebot commented Oct 29, 2019 •
edited
Loading

Size changes (stable)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against ef077d4

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 29, 2019

Here. This is maybe a little better.
Screen Shot 2019-10-29 at 1 57 25 PM

@bvaughn bvaughn merged commit 273679a into facebook:master Oct 31, 2019
@bvaughn bvaughn deleted the devtools-update-react-native-connect-text branch October 31, 2019 16:22
trueadm pushed a commit to trueadm/react that referenced this pull request Nov 4, 2019
@trueadm
DevTools standalone shell changes: (facebook#17213)
bb1d014 
* DevTools standalone shell changes:

1. Update React Native connection wording
2. Tweak styles slightly

* Tweaked standalone DevTools error warning text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone threepointone approved these changes

@gaearon gaearon Awaiting requested review from gaearon

@lunaruan lunaruan Awaiting requested review from lunaruan

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvaughn @sizebot @threepointone @facebook-github-bot