Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeSandbox CI Config #17175

Merged
merged 7 commits into from
Oct 31, 2019
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .codesandbox/ci.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"packages": ["packages/react", "packages/react-dom"],
"buildCommand": "build react/index,react-dom/index",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"buildCommand": "build react/index,react-dom/index",
"buildCommand": "build --type=UMD,NODE react/index,react-dom/index",

The other bundles won't be published anyway due to the publishDirectory.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need UMD, though

"publishDirectory": {
"react": "build/node_modules/react",
"react-dom": "build/node_modules/react-dom"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do Scheduler, too.

},
"sandboxes": ["new"]
}