Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeSandbox CI Config #17175

Merged
merged 7 commits into from
Oct 31, 2019
Merged

Add CodeSandbox CI Config #17175

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
600382c
Add CodeSandbox CI Config
CompuIves Oct 4, 2019
c0cfb1b
Add default sandbox to build
CompuIves Oct 4, 2019
27b51ba
Make build more efficient and add scheduler
CompuIves Oct 29, 2019
67e7828
Force build
CompuIves Oct 30, 2019
2083d74
Add scheduler image
CompuIves Oct 30, 2019
9679d9c
Add scheduler/tracing to the build
CompuIves Oct 31, 2019
a4e12fd
Force another build
CompuIves Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .codesandbox/ci.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"packages": ["packages/react", "packages/react-dom"],
"buildCommand": "build --type=NODE react/index,react-dom/index,scheduler/index",
"publishDirectory": {
"react": "build/node_modules/react",
"react-dom": "build/node_modules/react-dom",
"scheduler": "build/node_modules/scheduler"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause the same issue as mui/material-ui#17976 (comment):
react-dom declares a dependency on scheduler with the newly created version but codesandbox thinks this version is on the npm registry.

I guess this applies regardless of whether scheduler is built in the codesandbox CI or not.

},
"sandboxes": ["new"]
}