Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-interactions] Add onFocusWithin event to FocusWithin responder #17115

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 16, 2019

This adds the onFocusWithin event callback to the FocusWithin event responder. We already have onBlurWithin which is required for our rich internal focus management and accessibility component experiments and now we also need onFocusWithin so we can properly handle cases where we need to remember the last focused node in the cases where we have to restore focus.

@sizebot
Copy link

sizebot commented Oct 16, 2019

Details of bundled changes.

Comparing: 4cb399a...a0c50a0

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/focus.development.js +3.9% +0.9% 11.81 KB 12.27 KB 2.57 KB 2.59 KB UMD_DEV
react-interactions-events/press.development.js 0.0% -0.0% 9.02 KB 9.02 KB 2.66 KB 2.66 KB UMD_DEV
react-interactions-events/tap.development.js 0.0% -0.0% 18.17 KB 18.17 KB 3.92 KB 3.91 KB UMD_DEV
react-interactions-events/focus.production.min.js 🔺+2.6% 🔺+1.1% 4.31 KB 4.42 KB 1.46 KB 1.47 KB UMD_PROD
react-interactions-events/press.production.min.js 0.0% -0.1% 2.62 KB 2.62 KB 1.09 KB 1.09 KB UMD_PROD
react-interactions-events/tap.production.min.js 0.0% -0.1% 6.31 KB 6.31 KB 2.37 KB 2.36 KB UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.68 KB 2.68 KB 1006 B 1005 B UMD_DEV
react-interactions-events/input.development.js 0.0% -0.1% 4.52 KB 4.52 KB 1.44 KB 1.44 KB UMD_DEV
react-interactions-events/scroll.development.js 0.0% +0.1% 6.3 KB 6.3 KB 1.65 KB 1.65 KB UMD_DEV
react-interactions-events/input.production.min.js 0.0% -0.1% 1.84 KB 1.84 KB 984 B 983 B UMD_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.1% 2.63 KB 2.63 KB 1.15 KB 1.15 KB UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.2% 2.49 KB 2.49 KB 961 B 959 B NODE_DEV
react-interactions-events/input.development.js 0.0% -0.1% 4.34 KB 4.34 KB 1.4 KB 1.4 KB NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 668 B 667 B NODE_PROD
react-interactions-events/input.production.min.js 0.0% -0.2% 1.66 KB 1.66 KB 917 B 915 B NODE_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.1% 2.44 KB 2.44 KB 1.09 KB 1.09 KB NODE_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 7 KB 7 KB 1.56 KB 1.55 KB UMD_DEV
react-interactions-events/press-legacy.development.js 0.0% -0.0% 24.6 KB 24.6 KB 6.07 KB 6.07 KB UMD_DEV
react-interactions-events/hover.production.min.js 0.0% -0.1% 3.12 KB 3.12 KB 1.13 KB 1.13 KB UMD_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.0% 7.31 KB 7.31 KB 2.77 KB 2.77 KB UMD_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 6.82 KB 6.82 KB 1.51 KB 1.51 KB NODE_DEV
react-interactions-events/press-legacy.development.js 0.0% -0.0% 24.41 KB 24.41 KB 6.02 KB 6.02 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% -0.2% 2.94 KB 2.94 KB 1.07 KB 1.07 KB NODE_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.1% 7.13 KB 7.13 KB 2.71 KB 2.71 KB NODE_PROD
react-interactions-events/focus.development.js +3.9% +0.9% 11.63 KB 12.09 KB 2.53 KB 2.55 KB NODE_DEV
react-interactions-events/press.development.js 0.0% -0.1% 8.73 KB 8.73 KB 2.58 KB 2.58 KB NODE_DEV
react-interactions-events/tap.development.js 0.0% -0.1% 17.99 KB 17.99 KB 3.86 KB 3.86 KB NODE_DEV
react-interactions-events/focus.production.min.js 🔺+2.7% 🔺+1.1% 4.14 KB 4.25 KB 1.4 KB 1.42 KB NODE_PROD
react-interactions-events/press.production.min.js 0.0% -0.2% 2.33 KB 2.33 KB 1 KB 1 KB NODE_PROD
react-interactions-events/tap.production.min.js 0.0% -0.1% 6.15 KB 6.15 KB 2.32 KB 2.32 KB NODE_PROD
react-interactions-events/drag.development.js 0.0% -0.1% 5.23 KB 5.23 KB 1.54 KB 1.54 KB UMD_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.97 KB 5.97 KB 2.24 KB 2.24 KB UMD_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 6 KB 6 KB 1.63 KB 1.62 KB UMD_DEV
react-interactions-events/drag.production.min.js 0.0% -0.2% 2.25 KB 2.25 KB 1.07 KB 1.07 KB UMD_PROD
ReactEventsFocus-dev.js +4.2% +1.0% 11.59 KB 12.07 KB 2.54 KB 2.57 KB FB_WWW_DEV
react-interactions-events/swipe.production.min.js 0.0% -0.1% 2.45 KB 2.45 KB 1.11 KB 1.1 KB UMD_PROD
ReactEventsFocus-prod.js 🔺+3.3% 🔺+2.0% 8.5 KB 8.78 KB 1.79 KB 1.83 KB FB_WWW_PROD
react-interactions-events/swipe.development.js 0.0% -0.1% 5.82 KB 5.82 KB 1.58 KB 1.58 KB NODE_DEV
react-interactions-events/drag.production.min.js 0.0% -0.1% 2.88 KB 2.88 KB 1.38 KB 1.38 KB NODE_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.1% 2.27 KB 2.27 KB 1.05 KB 1.05 KB NODE_PROD

Generated by 🚫 dangerJS against a0c50a0

@trueadm trueadm merged commit 9169375 into facebook:master Oct 16, 2019
@trueadm trueadm deleted the add-focus-within branch October 16, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants