[react-interactions] Allow event.preventDefault on LegacyPress responder #17113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[react-interactions] Allow event.preventDefault on LegacyPress responder
What are those? And why did previous edge-cases not require this? |
|
@necolas See internal task 55775588. I've also had another team come to me and want similar, to call |
necolas
approved these changes
Oct 16, 2019
|
LegacyPress is likely too buggy for continued internal use and we should move them over to the Press module. So we might need to add this to other responders in that case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back
event.preventDefaultbehavior that and removes the previous warning for its usage. Whilst this might not be the right long term strategy, this change unblocks internal cases where the native events need to be prevented to handle edge-cases that are exposed because of the mixing of event systems and quirks with the systems in place. Furthermore, this is intentionally only for the LegacyPress responder.