[react-ui/events] Tap responder API changes #16827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necolas
force-pushed
the
react-ui/events/tap-api-changes
branch
3 times, most recently
from
eb7d5d3 to
8c8e412
Compare
Details of bundled changes.Comparing: e8c7dde...00aaea2 react-ui
|
trueadm
approved these changes
Sep 19, 2019
This patch limits the `onTap*` callbacks to the primary pointer button. Auxiliary button and modified primary button interactions call `onAuxiliaryTap`, cancel any active tap, and preserve the native behavior.
necolas
force-pushed
the
react-ui/events/tap-api-changes
branch
from
8c8e412 to
00aaea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch limits the
onTap*callbacks to the primary pointer button. Auxiliary button and modified primary button interactions callonAuxiliaryTap, cancel any active tap, and preserve the native behavior.This makes it easier to use
Tapfor primary pointer interactions while providing a basic way to record auxiliary taps for analytics, etc.