Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-events] Fix Scope listener issue #16658

Merged
merged 1 commit into from
Sep 4, 2019
Merged

[react-events] Fix Scope listener issue #16658

merged 1 commit into from
Sep 4, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Sep 4, 2019

This fixes an issue where event listeners on scopes would fail during the complete phase when a parent fiber was a host component. Added a test case for a regression test.

@trueadm trueadm requested a review from necolas September 4, 2019 17:43
@sizebot
Copy link

sizebot commented Sep 4, 2019

ReactDOM: size: 0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: 7126a37...9d54c83

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% 0.0% 656.91 KB 657.27 KB 143.08 KB 143.12 KB UMD_DEV
react-art.development.js +0.1% 0.0% 587.59 KB 587.95 KB 125.63 KB 125.67 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 66.94 KB 66.94 KB 20.4 KB 20.4 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 602.48 KB 603.18 KB 125.33 KB 125.4 KB FB_WWW_DEV
ReactART-prod.js -0.0% 🔺+0.1% 225.97 KB 225.92 KB 38.42 KB 38.47 KB FB_WWW_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 115.32 KB 115.32 KB 36.36 KB 36.35 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 142.1 KB 142.1 KB 37.12 KB 37.12 KB UMD_DEV
ReactDOM-dev.js +0.1% 0.0% 938.92 KB 939.62 KB 207.4 KB 207.48 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.8 KB 19.8 KB 7.36 KB 7.36 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 57.25 KB 57.25 KB 15.78 KB 15.78 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 55.52 KB 55.52 KB 15.45 KB 15.45 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.61 KB 3.61 KB 1.48 KB 1.48 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 🔺+0.1% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 915.12 KB 915.48 KB 207.42 KB 207.45 KB UMD_DEV
react-dom.development.js 0.0% 0.0% 909.21 KB 909.57 KB 205.73 KB 205.76 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 139.05 KB 139.05 KB 36.34 KB 36.34 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 111.68 KB 111.68 KB 35.39 KB 35.38 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.13 KB 20.13 KB 7.51 KB 7.5 KB NODE_PROD
ReactDOM-prod.js 🔺+0.1% 0.0% 372.2 KB 372.48 KB 68.22 KB 68.24 KB FB_WWW_PROD
ReactDOM-profiling.js +0.2% +0.1% 377.32 KB 378.03 KB 69.24 KB 69.3 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 138.04 KB 138.04 KB 36.11 KB 36.11 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.73 KB 19.73 KB 7.34 KB 7.34 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.75 KB 10.75 KB 3.68 KB 3.68 KB UMD_PROD
ReactDOMServer-prod.js 0.0% -0.0% 48.58 KB 48.58 KB 11.11 KB 11.11 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js +0.1% +0.1% 613.59 KB 614.27 KB 127.74 KB 127.81 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.21 KB 39.21 KB 9.95 KB 9.95 KB UMD_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 33.18 KB 33.18 KB 8.49 KB 8.49 KB NODE_DEV
react-test-renderer.development.js +0.1% 0.0% 600.95 KB 601.29 KB 128.4 KB 128.44 KB UMD_DEV
react-test-renderer.development.js +0.1% 0.0% 596.28 KB 596.63 KB 127.2 KB 127.24 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 68.57 KB 68.57 KB 20.9 KB 20.9 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% 0.0% 586.23 KB 586.59 KB 124.33 KB 124.37 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 19.25 KB 19.25 KB 6.33 KB 6.33 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% -0.2% 2.56 KB 2.56 KB 1.14 KB 1.14 KB NODE_PROD
react-reconciler-persistent.development.js +0.1% 0.0% 583.24 KB 583.6 KB 123.07 KB 123.1 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% -0.0% 68.95 KB 68.95 KB 20.45 KB 20.45 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-profiling.js 0.0% -0.0% 278.4 KB 278.4 KB 47.8 KB 47.8 KB RN_OSS_PROFILING
ReactFabric-prod.js 0.0% -0.0% 261.69 KB 261.69 KB 44.95 KB 44.95 KB RN_OSS_PROD
ReactFabric-dev.js +0.1% 0.0% 742.22 KB 742.91 KB 156.88 KB 156.95 KB RN_FB_DEV
ReactFabric-prod.js 0.0% -0.0% 261.7 KB 261.7 KB 44.96 KB 44.96 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.1% 0.0% 735.19 KB 735.89 KB 155.66 KB 155.72 KB RN_OSS_DEV
ReactNativeRenderer-dev.js +0.1% 0.0% 735.35 KB 736.05 KB 155.75 KB 155.81 KB RN_FB_DEV
ReactFabric-dev.js +0.1% 0.0% 742.05 KB 742.74 KB 156.81 KB 156.87 KB RN_OSS_DEV

Generated by 🚫 dangerJS against 9d54c83

@trueadm trueadm merged commit 9ff60ff into facebook:master Sep 4, 2019
@trueadm trueadm deleted the tweak-scope branch September 4, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueadm @sizebot @necolas @facebook-github-bot