Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[ESLint] Forbid top-level use*() calls (#16455)" #16522

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Revert "[ESLint] Forbid top-level use*() calls (#16455)" #16522

merged 1 commit into from
Aug 21, 2019

Conversation

threepointone
Copy link
Contributor

This reverts commit 96eb703.

@threepointone threepointone requested a review from gaearon August 21, 2019 09:12
@sizebot
Copy link

sizebot commented Aug 21, 2019

Details of bundled changes.

Comparing: efa5dbe...70b40cc

eslint-plugin-react-hooks

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
eslint-plugin-react-hooks.development.js -0.4% 0.0% 75.31 KB 75.01 KB 17.31 KB 17.32 KB NODE_DEV
eslint-plugin-react-hooks.production.min.js -1.0% 🔺+0.3% 20.14 KB 19.95 KB 6.89 KB 6.91 KB NODE_PROD
ESLintPluginReactHooks-dev.js -0.5% -0.1% 80.87 KB 80.5 KB 17.84 KB 17.83 KB FB_WWW_DEV

Generated by 🚫 dangerJS

@threepointone threepointone merged commit 507f0fb into facebook:master Aug 21, 2019
@threepointone
Copy link
Contributor Author

Landed to unblock sync

@threepointone threepointone deleted the revert-top-level-use-calls branch August 21, 2019 09:20
@gaearon gaearon mentioned this pull request Aug 21, 2019
Merged
gaearon added a commit that referenced this pull request Aug 21, 2019
@gaearon
Revert "Revert "[ESLint] Forbid top-level use*() calls (#16455)" (#16522
a7e2223 
)"

This reverts commit 507f0fb.
gaearon added a commit that referenced this pull request Aug 21, 2019
@gaearon
Revert "Revert "[ESLint] Forbid top-level use*() calls (#16455)" (#16522
32d221a 
)"

This reverts commit 507f0fb.
gaearon added a commit that referenced this pull request Aug 21, 2019
@gaearon
Revert "Revert "[ESLint] Forbid top-level use*() calls (#16455)"" (#1…
c433fbb 
…6525)

* Revert "Revert "[ESLint] Forbid top-level use*() calls (#16455)" (#16522)"

This reverts commit 507f0fb.

* Update RulesOfHooks.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@threepointone @sizebot @facebook-github-bot