Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flare] Remove FocusScope responder #16267

Merged
merged 1 commit into from
Jul 31, 2019
Merged

[Flare] Remove FocusScope responder #16267

merged 1 commit into from
Jul 31, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jul 31, 2019

We plan on breaking out the focus management system from the event system, so that means that FocusScope no longer makes sense being an event responder.

@trueadm trueadm requested a review from necolas July 31, 2019 16:32
TrySound
TrySound approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@TrySound TrySound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope to see it soon :)

@sizebot
Copy link

sizebot commented Jul 31, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@trueadm trueadm mentioned this pull request Jul 31, 2019
Merged
@trueadm trueadm merged commit b5af4fe into facebook:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@necolas necolas necolas approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trueadm @sizebot @necolas @TrySound @facebook-github-bot