Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Check tag before calling hook effects #16215

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jul 26, 2019

Adds a missing tag check before calling passive effects.

The reason we didn't catch this earlier is because it happens to accidentally work even without the check in most cases.

I added a regression test but it's very specific and weird and you should feel free to delete it later if the implementation details change and it causes you problems. I split this into the first commit to show that the test fails.

The second commit adds the tag check, to show that it fixes the test.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept to unblock but we need to fix DEV case too + test

@sizebot
Copy link

sizebot commented Jul 26, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@acdlite acdlite force-pushed the check-tag-passive-effects branch from 96d8d2b to 8a00b67 Compare July 26, 2019 18:02
Next commit fixes it.
@acdlite acdlite force-pushed the check-tag-passive-effects branch from 8a00b67 to a59be45 Compare July 26, 2019 21:08
acdlite added a commit to acdlite/react that referenced this pull request Jul 26, 2019
Next commit fixes it.
@acdlite acdlite force-pushed the check-tag-passive-effects branch 2 times, most recently from 1f88498 to 8080fb7 Compare July 26, 2019 21:15
acdlite added a commit to acdlite/react that referenced this pull request Jul 26, 2019
Next commit fixes it.
@acdlite acdlite force-pushed the check-tag-passive-effects branch from 8080fb7 to 563fe76 Compare July 26, 2019 21:15
TODO: Test that triggers this
@acdlite acdlite merged commit ed57bf8 into facebook:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants