-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Suspense Priority Warning Message #16186
Edit Suspense Priority Warning Message #16186
Conversation
…ng message to the beginning of the message
No significant bundle size changes to report. Generated by 🚫 dangerJS |
Here's my suggested text:
|
If it was triggered by the root, then the message should be:
and we'll add a separate warning inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Probably isn't the last time we'll bikeshed this message before releasing :D
Are you using Concurrent Mode as an unstable API? It’s not officially supported. |
@gaearon I know it's unstable yet, but we're using it already and it's good enough as far as we can see... we have some use case in which it improved performance a lot. Just wondering if I can find any reference about this warning, orherwise it's fine... I'll wait :) |
move 'component that triggered the update' in suspense priority warning message to the beginning of the message instead of the middle for better readability
Message after update: