[Flare] Revise responder event types #16081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 2a0f639...4f529a3 react-dom
Generated by 🚫 dangerJS |
necolas
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes responder event types to always be strings, rather than the confusing mix of either string or object (for when something needs to be marked as passive). So previously, you'd do this
{name: 'click', passive: false}. With this change, you'd do"click_active".From doing this, we can get rid of a bunch of confusing branch code and unify the event targets of both DOM and RN responders so they're just
Array<string>. So this also removes a lot of Flow generics abstraction too.The net result is less memory used and faster runtime performance as we no longer generate sets and listening keys, instead we loop over the small array. Looping over a small array of strings (< 10 elements) was 5x faster than converting to a key and using that as a key to lookup existence within a Set.