chore: use jest-serializer-raw for react-fresh snapshots #15806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
raw-snapshot-fresh
branch
2 times, most recently
from
576ad53
to
7841236
Compare
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
|
Why isn't this the default? |
|
Not sure... There is jestjs/jest#2482 which implemented the current behavior and jestjs/jest#4183 which tried to fix it, although I don't remember why it stalled |
gaearon
pushed a commit
to gaearon/react
that referenced
this pull request
Jun 19, 2019
rickhanlonii
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in https://github.com/facebook/react/pull/15733/files#r289843934. I personally find the snapshots easier to read without the escaped junk
Zero hard feelings if you disagree, this took less than 5 minutes to put together 🙂