Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using the wrong renderer's act() should warn #15756

Merged
merged 6 commits into from
May 29, 2019
Merged

using the wrong renderer's act() should warn #15756

merged 6 commits into from
May 29, 2019

Commits on May 28, 2019

  1. warn when using the wrong renderer's act around another renderer's up… 

    …dates

like it says. it uses a real object as the sigil (instead of just a boolean). specifically, it uses a renderer's flushPassiveEffects as the sigil. We also run tests for this separate from our main suite (which doesn't allow loading multiple renderers in a suite), but makes sure to run this in CI as well.
    @threepointone
    threepointone committed May 28, 2019
    Configuration menu
    Copy the full SHA
    5b186a6 View commit details
    Browse the repository at this point in the history

  2. unneeded (and wrong) comment

    @threepointone
    threepointone committed May 28, 2019
    Configuration menu
    Copy the full SHA
    e789900 View commit details
    Browse the repository at this point in the history

  3. run the dom fixture on CI

    @threepointone
    threepointone committed May 28, 2019
    Configuration menu
    Copy the full SHA
    a2dae63 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. update the sigil only in __DEV__

    @threepointone
    threepointone committed May 29, 2019
    Configuration menu
    Copy the full SHA
    6d64194 View commit details
    Browse the repository at this point in the history

  2. remove the obnoxious comment

    @threepointone
    threepointone committed May 29, 2019
    Configuration menu
    Copy the full SHA
    669d92e View commit details
    Browse the repository at this point in the history

  3. use an explicit export for the sigil

    @threepointone
    threepointone committed May 29, 2019
    Configuration menu
    Copy the full SHA
    c0dc398 View commit details
    Browse the repository at this point in the history