Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Suspense Boundary Context (and unstable_avoidThisFallback) #15578

Merged
merged 4 commits into from
May 8, 2019
Merged

Add Suspense Boundary Context (and unstable_avoidThisFallback) #15578

merged 4 commits into from
May 8, 2019
+280 −17

Commits on May 8, 2019

  1. Avoidable suspense boundaries

    @sebmarkbage
    sebmarkbage committed May 8, 2019
    Configuration menu
    Copy the full SHA
    d029d8c View commit details
    Browse the repository at this point in the history

  2. Move the context out of SuspenseComponent

    @sebmarkbage
    sebmarkbage committed May 8, 2019
    Configuration menu
    Copy the full SHA
    edc20da View commit details
    Browse the repository at this point in the history

  3. Use setDefaultShallowSuspenseContext instead of passing 0 

    GCC doesn't optimize this case. Saves us a couple of bytes and is shorter.
    @sebmarkbage
    sebmarkbage committed May 8, 2019
    Configuration menu
    Copy the full SHA
    98c9e9c View commit details
    Browse the repository at this point in the history

  4. Typos

    @acdlite @sebmarkbage
    acdlite authored and sebmarkbage committed May 8, 2019
    Configuration menu
    Copy the full SHA
    b415837 View commit details
    Browse the repository at this point in the history