Event API: use capture for all event listeners using experimental responder system
#15526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
changed the title
capture for all event listeners using experimental responder system
trueadm
changed the title
capture for all event listeners using experimental responder systemcapture for all event listeners using experimental responder system
|
ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: cc5a493...329292a react-dom
Generated by 🚫 dangerJS |
necolas
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all experimental event API listeners use the
capturephase of event listening. Given that the experimental event API is fully virtualized, we can dispatchcaptureandbubbleevents using the event system, rather than using the DOM propagation system. Not only does this give us much greater control over what gets dispatched and how it gets dispatched, it also allows us to traverse through portals and other abstract concepts. Furthermore, by being in the capture phase, we are sure to get the event before other event listeners – meaning they are unlikely tostopImmediatePropgationon React. Note: event components are not affected by this change – they can still dispatch capture and bubble events back to the user.This remove a whole lot of code. I'll add follow up tests in the comings days, unless @necolas has bandwidth to do that earlier.