Measure callback timeout relative to current time #15479
Merged
+48
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the timeout passed to `scheduleCallback` represented an absolute timestamp, instead of the amount of time until that timestamp is reached. The solution is to subtract the current time from the expiration. The bug wasn't caught by other tests because we use virtual times that default to 0, and most tests don't advance time. I also moved the `initialTimeMs` offset to the `SchedulerWithReactIntegration` module so that we don't have to remember to subtract the offset every time. (We should consider upstreaming this to the Scheduler package.)
acdlite
force-pushed
the
relative-callback-timeout
branch
from
a2f430c
to
36dc9da
Compare
|
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Details of bundled changes.Comparing: 9ebe176...36dc9da react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
sebmarkbage
approved these changes
Apr 23, 2019
| export const shouldYield = disableYielding | ||
| ? () => false // Never yield when `disableYielding` is on | ||
| : Scheduler_shouldYield; | ||
|
|
||
| let immediateQueue: Array<SchedulerCallback> | null = null; | ||
| let immediateQueueCallbackNode: mixed | null = null; | ||
| let isFlushingImmediate: boolean = false; | ||
| let initialTimeMs: number = Scheduler_now(); |
There was a problem hiding this comment.
Should this be const?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the timeout passed to
scheduleCallbackrepresented an absolute timestamp, instead of the amount of time until that timestamp is reached. The solution is to subtract the current time from the expiration.The bug wasn't caught by other tests because we use virtual times that default to 0, and most tests don't advance time.
I also moved the
initialTimeMsoffset to theSchedulerWithReactIntegrationmodule so that we don't have to remember to subtract the offset every time. (We should consider upstreaming this to the Scheduler package.)