Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: disablePictureInPicture attribute for HTML5 videos #15334

Merged
merged 4 commits into from
Apr 25, 2019
Merged

ADD: disablePictureInPicture attribute for HTML5 videos #15334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae2c9a1
ADD: disablePictureInPicture attribute for HTML5 videos
eek Apr 5, 2019
23ddcb6
ADD: disablePictureInPicture as DOMProperty and attribute
eek Apr 6, 2019
0e2568e
Update: Replace camelCase with lowercase and vice-versa
eek Apr 6, 2019
3c5c4bb
FIX: Missing comma on attribute (prettier)
eek Apr 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions fixtures/attribute-behavior/src/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,11 @@ const attributes = [
read: getSVGAttribute('direction'),
},
{name: 'disabled', tagName: 'input'},
{
name: 'disablePictureInPicture',
tagName: 'video',
read: getProperty('disablepictureinpicture'),
},
{
name: 'display',
tagName: 'svg',
Expand Down
1 change: 1 addition & 0 deletions packages/react-dom/src/shared/DOMProperty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ const properties = {};
'default',
'defer',
'disabled',
'disablePictureInPicture',
'formNoValidate',
'hidden',
'loop',
Expand Down
1 change: 1 addition & 0 deletions packages/react-dom/src/shared/possibleStandardNames.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const possibleStandardNames = {
defer: 'defer',
dir: 'dir',
disabled: 'disabled',
disablepictureinpicture: 'disablePictureInPicture',
download: 'download',
draggable: 'draggable',
enctype: 'encType',
Expand Down