Refactor event object creation for the experimental event API #15295
+348
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: f243dea...2b5dde8 react-dom
react-events
Generated by 🚫 dangerJS |
necolas
reviewed
Apr 2, 2019
necolas
approved these changes
Apr 2, 2019
| let i, length; | ||
|
|
||
| if (capture !== null) { | ||
| for (i = capture.length; i-- > 0; ) { |
There was a problem hiding this comment.
Suggested change
| for (i = capture.length; i-- > 0; ) { | |
| for (let i = capture.length - 1; i > 0; i -= 1) { |
There was a problem hiding this comment.
I actually find that a bit harder to read, maybe it's me?
There was a problem hiding this comment.
I find @necolas's version to be more idiomatic.
There was a problem hiding this comment.
The version I used was also the same as the one currently in React, not that it matters.
TBH it's all personal preference, if you both feel strongly, I can address in a follow up later this week :)
| } | ||
| } | ||
| if (bubble !== null) { | ||
| for (i = 0, length = bubble.length; i < length; ++i) { |
There was a problem hiding this comment.
Suggested change
| for (i = 0, length = bubble.length; i < length; ++i) { | |
| for (let i = 0; i < bubble.length; i += 1) { |
There was a problem hiding this comment.
I moved the length out intentionally here, just because it's generally faster at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the experimental event API to use event objects at the point of the responder module, rather than via indirection through the responder context
dispatchEvent. This allows responder events to be strongly typed and it also means we can avoid using the plugin event system to dispatch the event and instead handle the event directly within the responder system itself.Furthermore, this removes
stopPropagationandpreventDefaultfrom event objects. The short term expectation is that their functionality will exist again but, instead of imperative method calls, the behaviour will live inside the React component tree. This will happen in follow up PRs.