New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve async useEffect warning #15104

Merged

gaearon merged 1 commit into facebook:master from gaearon:new-useeffect-warning

Mar 13, 2019

Collaborator

gaearon commented Mar 13, 2019

Move the function inside an effect to reduce the confusion about deps (Add more info to FAQ about deps reactjs/react.dev#1815).
Tweak capitalization (doesn't really matter but we don't capitalize effects in docs).
Add a link which goes into our FAQ and itself links to a CodeSandbox demo and an article. This will unblock people who are confused about data fetching.


          Improve async useEffect warning

2db5b9e

gaearon requested a review from threepointone

March 13, 2019 16:05

facebook-github-bot added the CLA Signed label

threepointone approved these changes

View reviewed changes

gaearon merged commit 9d77a31 into facebook:master

gaearon added a commit to gaearon/react that referenced this pull request


          Improve async useEffect warning (facebook#15104)

13a3788

gaearon mentioned this pull request

React v16.8.5 #15192

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels