[ESLint] Warn about dependencies outside of render scope #14990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a better warning for these cases:
We used to warn before, too, but the message wasn't very specific (it just said it's unused). Later #14967 disabled that message for effects, but that wasn't intentional. This particular case should still warn.
This PR re-adds the warnings along with a bunch of new tests covering it. It detects if we used an identifier that's outside the component scope, and warns that it's essentially a mutable value.
In the docs, we'll explain that the fix is either to omit it, or (if you really want to track it), put it into state and update appropriately.