-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 16.8.0 changelog and update some READMEs #14692
Conversation
IT'S HAPPENING, 4th of February! |
🎣 |
YESSS! 💥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include the breaking API changes, that we haven't made yet, into the change log too.
I’ll add the useReducer one, is there more? |
I'm curious about the fate of useCallback. It seemed to be the one most likely to change early on. |
No changes planned to it for now. On a side note — we appreciate the community excitement but it’s creating some noise across issues and PRs that makes it more challenging to get the work done and make sure we don’t forget anything. We’d appreciate a bit patience and restraint in posting until we flesh the details out and push the release. I put a date as an estimate but we’ve already moved it a few times, and won’t hesitate to move it again if we don’t feel the release is solid enough. It will be ready when it’s ready. Thanks. |
So no kind of useErrorBoundary hook before release? Was looking forward to ridding of my last class component but this is none the less exciting news. Excellent job, I can't wait! |
Co-Authored-By: gaearon <[email protected]>
No, it wouldn’t be a good candidate for a Hook. This is about different example but maybe it helps: https://overreacted.io/why-isnt-x-a-hook/ |
I am so proud of this community 😊 |
It's time! |
What time is it released?😄 |
i don't think the requested changes were addressed :( |
CHANGELOG.md
Outdated
@@ -6,6 +6,33 @@ | |||
</summary> | |||
</details> | |||
|
|||
## 16.8.0 (Maybe February 4, 2019 but we've moved it before so please don't rely on it.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you delete this maybe, it will surely release if you do 🥑
I am still waiting for what I was looking forward to. |
Good things come for those who wait 👍 |
*insert waiting pablo escobar meme here* |
CHANGELOG.md
Outdated
|
||
* Support Hooks in the shallow renderer. ([@trueadm](https://github.com/trueadm) in [#14567](https://github.com/facebook/react/pull/14567)) | ||
* Fix wrong state in `shouldComponentUpdate` in the presence of `getDerivedStateFromProps` for Shallow Renderer. ([@chenesan](https://github.com/chenesan) in [#14613](https://github.com/facebook/react/pull/14613)) | ||
* Add `ReactTestUtils.act()` for batching updates so that tests more closely match real behavior. ([@threepointone](https://github.com/threepointone) in [#14744]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link doesn’t work. Needs to be an actual link.
Also technically not test renderer but test utils. See past Changelogs.
Or I guess there should be two entries because there are two new APIs. One in test renderer section and one in test utils.
* Add 16.8.0 changelog * Mention ESLint plugin * Remove experimental notices from the ESLint plugin README * Update CHANGELOG.md * Add more details for Hooks * fix * Set a date * Update CHANGELOG.md Co-Authored-By: gaearon <[email protected]> * Update CHANGELOG.md * useReducer in changelog * Add to changelog * Update date * Add facebook#14119 to changelog * Add facebook#14744 to changelog * Fix PR links * act() method was added to test utils, too * Updated release date to February 6th
* Add 16.8.0 changelog * Mention ESLint plugin * Remove experimental notices from the ESLint plugin README * Update CHANGELOG.md * Add more details for Hooks * fix * Set a date * Update CHANGELOG.md Co-Authored-By: gaearon <[email protected]> * Update CHANGELOG.md * useReducer in changelog * Add to changelog * Update date * Add facebook#14119 to changelog * Add facebook#14744 to changelog * Fix PR links * act() method was added to test utils, too * Updated release date to February 6th
* Add 16.8.0 changelog * Mention ESLint plugin * Remove experimental notices from the ESLint plugin README * Update CHANGELOG.md * Add more details for Hooks * fix * Set a date * Update CHANGELOG.md Co-Authored-By: gaearon <[email protected]> * Update CHANGELOG.md * useReducer in changelog * Add to changelog * Update date * Add facebook#14119 to changelog * Add facebook#14744 to changelog * Fix PR links * act() method was added to test utils, too * Updated release date to February 6th
Not sure what's going on with this PR. The "Squash and merge" button does nothing (just times out) but the commit has already been merged– (I've verified the contents of master against this PR)– so I'm going to just close it. |
@bvaughn is it because this is synced with some internal system? |
No. We do development GitHub first. (We do sync from GitHub to our internal Mercurial repo, but not the other way around.) |
NOTE BEFORE MERGE: set the release date.