-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable hooks by default for FB React Native renderer #14435
Enable hooks by default for FB React Native renderer #14435
Conversation
@@ -23,6 +22,7 @@ export const { | |||
} = require('ReactFeatureFlags'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of these, are they still relevant to be dynamic or can we just turn them on or off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only debugRenderPhaseSideEffects
is currently dynamically configured internally.
We always set debugRenderPhaseSideEffectsForStrictMode
to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like debugRenderPhaseSideEffects
is a dynamic value, debugRenderPhaseSideEffectsForStrictMode
is being set to true in InitializeReactFeatureFlags
, and nothing is changing the default value of warnAboutDeprecatedLifecycles
.
Details of bundled changes.Comparing: a22880e...f7eaa2d react-native-renderer
Generated by 🚫 dangerJS |
I've pushed another commit to this branch that makes all but one of the flags ( Here are the new flag values:
|
* Enable hooks by default for FB React Native renderer * Updated RN+FB feature flags to make some of the dynamic ones static
* Enable hooks by default for FB React Native renderer * Updated RN+FB feature flags to make some of the dynamic ones static
No description provided.