[WIP] Refactor beginWork replay #14130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
refactor-replay
branch
from
8f1199b
to
10eddb1
Compare
|
ReactDOM: size: -0.0%, gzip: -0.0% Details of bundled changes.Comparing: 3c69a18...10eddb1 react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
scheduler
Generated by 🚫 dangerJS |
acdlite
reviewed
Nov 7, 2018
| } catch (thrownValue) { | ||
| resetContextDependences(); | ||
| resetHooks(); | ||
| if (nextUnitOfWork === null) { |
There was a problem hiding this comment.
I don't think there's any way to hit this condition. nextUnitOfWork should always be workInProgress.
|
@acdlite Do you still care that I follow up on this refactor? |
|
I addressed this when I rewrote the work loop last year so we can close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, doesn’t work
I want to follow up on #14104 (comment) and try to simplify this logic.
So far, I've tried to separate
beginWorkInDEVthat would callbeingWorkand fall back toreplayin acatchblock. A dozen tests are currently failing with a context mismatch or something like this, but I’m not sure why. I also realized that there might be a reason replaying callsworkLooprather thanbeginWorkdirectly (which seems like it would be simpler?) — for example,beginWorkmight assume the profiler timer has already started. So we need to make sure that any initialization that happens prior tobeginWorkalso happens on the replay code path, or revert to callingworkLoop.