Fix lazy() with defaultProps #14112
Merged
Fix lazy() with defaultProps #14112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw this probably means DevTools would also be wrong since they read off |
|
ReactDOM: size: -4.6%, gzip: -5.1% Details of bundled changes.Comparing: fd1256a...40aeb2e react
react-dom
react-art
react-test-renderer
react-reconciler
create-subscription
react-native-renderer
scheduler
react-cache
Generated by 🚫 dangerJS |
sebmarkbage
reviewed
Nov 5, 2018
| @@ -12,6 +12,21 @@ import type {LazyComponent, Thenable} from 'shared/ReactLazyComponent'; | |||
| import {Resolved, Rejected, Pending} from 'shared/ReactLazyComponent'; | |||
| import warning from 'shared/warning'; | |||
|
|
|||
| export function resolveDefaultProps(Component, baseProps) { | |||
There was a problem hiding this comment.
I think this is not just used for lazy.
There was a problem hiding this comment.
Even if it was this would be the wrong place for it.
There was a problem hiding this comment.
I can move to shared and reuse from ReactElement too. Couldn’t find a nice existing place.
There was a problem hiding this comment.
I don’t like shared. I prefer copying to putting things in shared. Makes it impossible to special case and encourages abstracting.
There was a problem hiding this comment.
So where do you want it? I guess I can create a file in the reconciler package but I don’t see why it deserves that when conceptually it’s related to our design for lazy.
There was a problem hiding this comment.
I kept it in LazyComponent for now because I don't want to duplicate it in reconciler bundle twice.
sebmarkbage
requested changes
Nov 5, 2018
|
It made sense to do this lazily when we only did this on render. But now we do the work multiple times. Not sure that makes sense. |
gaearon
force-pushed
the
lazy-fix
branch
2 times, most recently
from
0083e4b
to
ed49616
Compare
Pushed. |
This is an optimization. I'm not sure it's entirely safe. It's probably worth running internal tests and see if we can ever trigger a case where they're different. This can mess with resuming.
This reverts part of the previous commit. It broke a test that verifies we use current props in componentWillUnmount if the fiber unmounts due to an error.
acdlite
approved these changes
Nov 6, 2018
This was referenced Nov 7, 2018
This was referenced Dec 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Resolve defaultProps for Lazy components * Make test fail again * Undo the partial fix * Make test output more compact * Add a separate failing test for sync mode * Clean up tests * Add another update to both tests * Resolve props for commit phase lifecycles * Resolve prevProps for begin phase lifecycles * Resolve prevProps for pre-commit lifecycles * Only resolve props if element type differs * Fix Flow * Don't set instance.props/state during commit phase This is an optimization. I'm not sure it's entirely safe. It's probably worth running internal tests and see if we can ever trigger a case where they're different. This can mess with resuming. * Keep setting instance.props/state before unmounting This reverts part of the previous commit. It broke a test that verifies we use current props in componentWillUnmount if the fiber unmounts due to an error.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Resolve defaultProps for Lazy components * Make test fail again * Undo the partial fix * Make test output more compact * Add a separate failing test for sync mode * Clean up tests * Add another update to both tests * Resolve props for commit phase lifecycles * Resolve prevProps for begin phase lifecycles * Resolve prevProps for pre-commit lifecycles * Only resolve props if element type differs * Fix Flow * Don't set instance.props/state during commit phase This is an optimization. I'm not sure it's entirely safe. It's probably worth running internal tests and see if we can ever trigger a case where they're different. This can mess with resuming. * Keep setting instance.props/state before unmounting This reverts part of the previous commit. It broke a test that verifies we use current props in componentWillUnmount if the fiber unmounts due to an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on failing tests from #14108.
Fixes #13960.
I might have missed something. Just pushing it before going home. I haven't thought about the perf impact of this. Maybe we need to change the strategy and store them?