Always bail out timed out children even if they receive an update #13901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow, whoever paired on this with you must be really smart |
Details of bundled changes.Comparing: 0fc0446...5c466bb scheduler
Generated by 🚫 dangerJS |
The fragment that wraps timed-out children should always have an expiration time of NoWork.
acdlite
force-pushed
the
bailout-primary-children
branch
from
bf584c8
to
36765f1
Compare
sebmarkbage
approved these changes
Oct 20, 2018
linjiajian999
pushed a commit
to linjiajian999/react
that referenced
this pull request
Oct 22, 2018
…cebook#13901) * Always bail out timed out children even if they receive an update The fragment that wraps timed-out children should always have an expiration time of NoWork. * Don't need to set expirationTime, only childExpirationTime
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…cebook#13901) * Always bail out timed out children even if they receive an update The fragment that wraps timed-out children should always have an expiration time of NoWork. * Don't need to set expirationTime, only childExpirationTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fragment that wraps timed-out children should always have an expiration time of NoWork.