Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attribute table #13343

Merged
merged 3 commits into from
Aug 7, 2018
Merged

Update attribute table #13343

merged 3 commits into from
Aug 7, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Aug 7, 2018

Looks like we missed some updates. Chrome itself also did a few changes.
See separate commits:

@gaearon
Copy link
Collaborator Author

gaearon commented Aug 7, 2018

Going to merge since I need to rebase my PR on top.
I think this looks good.

31c1446 looked a bit suspicious to me, but it does seem like a valid bugfix. Checked (uppercase) changed but we warn about it. The defaultChecked change actually makes the property represent what user sees on the screen instead of always being false.

@gaearon gaearon merged commit a66217b into facebook:master Aug 7, 2018
@gaearon gaearon deleted the update-tab branch August 7, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants