Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor findHostInstance and findNodeHandle #12575

Merged
merged 3 commits into from
Apr 10, 2018
Merged

Refactor findHostInstance and findNodeHandle #12575

merged 3 commits into from
Apr 10, 2018

Commits on Apr 10, 2018

  1. Move findNodeHandle into the renderers and use instantiation 

    This is just like ReactDOM does it. This also lets us get rid of injection
for findNodeHandle. Instead I move NativeMethodsMixin and ReactNativeComponent
to use instantiation.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    5f90178 View commit details
    Browse the repository at this point in the history

  2. Refactor findHostInstance 

    The reconciler shouldn't expose the Fiber data structure. We should pass
the component instance to the reconciler, since the reconciler is the
thing that is supposed to be instancemap aware.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    2e2fa9c View commit details
    Browse the repository at this point in the history

  3. Fix devtools injection

    @sebmarkbage
    sebmarkbage committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    cf454c5 View commit details
    Browse the repository at this point in the history