Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmark runner #11749

Merged
merged 1 commit into from
Dec 2, 2017
Merged

Fix benchmark runner #11749

merged 1 commit into from
Dec 2, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 1, 2017

I used it today, and decided to change a few things to make it more usable.

  • Fixed lighthouse dependency version, this one is broken.
  • Fixed instructions to match Yarn 1.0 syntax and the command name.
  • Removed the build stats table: we already have it on the build.
  • This allowed me to always build just React/ReactDOM UMDs without being confusing. Since otherwise the build is impossibly slow for iteration, and I ended up building just React/ReactDOM UMDs anyway.

@gaearon gaearon merged commit 8540768 into facebook:master Dec 2, 2017
@sophiebits sophiebits mentioned this pull request Dec 4, 2017
Closed
@aickin
Copy link
Contributor

aickin commented Dec 4, 2017

Hey @gaearon, I'm still having lighthouse related issues with the bench script on master, and I'm not seeing any changes in this PR related to lighthouse. Is it possible you missed checking in package.json or something like that?

@gaearon gaearon deleted the fix-bench-2 branch December 4, 2017 13:22
@gaearon
Copy link
Collaborator Author

gaearon commented Dec 4, 2017

Yeah, not sure how that happened.

@gaearon
Copy link
Collaborator Author

gaearon commented Dec 4, 2017

Pushed the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @aickin @facebook-github-bot