Use prettier api #11458
Merged
Use prettier api #11458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
requested changes
Nov 5, 2017
scripts/prettier/index.js
Outdated
| const args = Object.keys(defaultOptions).reduce((acc, _key) => { | ||
| const camelize = /[\-\:]([a-z])/g; | ||
| const capitalize = token => token[1].toUpperCase(); | ||
| const prettierKey = _key.replace(camelize, capitalize); |
There was a problem hiding this comment.
This is unnecessary. Just convert the options to use camel case form instead where they are defined.
gaearon
reviewed
Nov 5, 2017
scripts/prettier/index.js
Outdated
| e.stdout | ||
| ); | ||
| process.exit(1); | ||
| const args = Object.keys(defaultOptions).reduce((acc, _key) => { |
There was a problem hiding this comment.
Can we just use Object.assign({}, options, defaultOptions) here?
mihalskiy
approved these changes
Nov 5, 2017
gaearon
approved these changes
Nov 5, 2017
|
Thanks! |
|
When there is a syntax error, I now see a useless Babylon stack trace. Could you please change the output to only keep the message and the code frame but omit the stack trace? |
Merged
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* use prettier-api * fix string to boolean * fix eslint * fix typo * cleanup * use object assign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9500