add classWithRenderNotExtended warning #11149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
requested changes
Oct 10, 2017
| classWithRenderNotExtended, | ||
| 'Using a class with a render method as a function, ' + | ||
| 'did you forget to extend React.Component?', | ||
| ); |
There was a problem hiding this comment.
Let's make this a warning instead, so that we can strip this out in production.
if (__DEV__) {
warning(workInProgress.type.prototype &&
+ workInProgress.type.prototype.render, '...');
}There was a problem hiding this comment.
thanks sebastian - just doublechecking before I fix - the issue discussion last left saying it should be an invariant outside a __DEV__ block (see here) - are you sure you want it just as a warning?
There was a problem hiding this comment.
regardless, i will resubmit as requested :) really honored to help.
|
I screwed up in my own repo and will restart this PR. thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! adding the fix for #10103. test/prettier/lint/flow all done and passing.