Use github tarball link for esprima dependency #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that (at least for local development) npm has a long standing bug where it doesn't recognize changing dependencies stored as git urls (see https://github.com/isaacs/npm/issues/1727). Luckily npm understand tarballs and GitHub provides tarballs for every commit, so the workaround is easy, though unfortunate.
benjamn
added a commit
that referenced
this pull request
Jun 19, 2013
Use github tarball link for esprima dependency
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 17, 2020
Summary --- Implement User Timing marks view as a fixed-height row above our React events. Also adds a tooltip for them. Colors [obtained from Firefox Profiler](https://github.com/firefox-devtools/profiler/blob/c4f68f423c7035a094952311addd0af5bec209e7/src/utils/colors.js#L26-L27) to match Firefox's Marker Chart. The colors aren't the best since they kind of upstage the React events. Resolves #72 iteration 1. This PR does not display User Timing measures due to the complexities of displaying a stack of User Timing measures. I also don't know how to identify a measure's start/end marks, so I'm not able to implement highlighting of related marks. We can create a separate issue for User Timing measures (#72 iteration 3). Test Plan --- * `yarn lint` * `yarn flow`: no type errors in changed code. Also fixed type errors in `EventTooltip`; 24 errors remaining. * `yarn test`: tests for `preprocessData` updated. * `yarn start`: tested with Facebook.com profile
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 19, 2020
Summary --- Implement User Timing marks view as a fixed-height row above our React events. Also adds a tooltip for them. Colors [obtained from Firefox Profiler](https://github.com/firefox-devtools/profiler/blob/c4f68f423c7035a094952311addd0af5bec209e7/src/utils/colors.js#L26-L27) to match Firefox's Marker Chart. The colors aren't the best since they kind of upstage the React events. Resolves #72 iteration 1. This PR does not display User Timing measures due to the complexities of displaying a stack of User Timing measures. I also don't know how to identify a measure's start/end marks, so I'm not able to implement highlighting of related marks. We can create a separate issue for User Timing measures (#72 iteration 3). Test Plan --- * `yarn lint` * `yarn flow`: no type errors in changed code. Also fixed type errors in `EventTooltip`; 24 errors remaining. * `yarn test`: tests for `preprocessData` updated. * `yarn start`: tested with Facebook.com profile
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that (at least for local development) npm has a long
standing bug where it doesn't recognize changing dependencies stored as
git urls (see https://github.com/isaacs/npm/issues/1727). Luckily npm
understand tarballs and GitHub provides tarballs for every commit, so
the workaround is easy, though unfortunate.
We'll want to put out a 0.3.x for this so that we don't break it when @jeffmo updates esprima