-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning deduplication in attribute table #10594
Conversation
After pulling this branch, the attr test harness totally crushes my Chrome. So bad that I can't even use Chrome's Task Manager to kill tabs. None of my other tabs (eg Messenger) accept text input, etc. |
It actually hung so badly I restarted my computer initially. Then as soon as I tried re-opening Chrome- (because of the service workers)- it auto-started and did the same thing. Took me a few minutes of trying to close the tab before it finally closed, then everything was back to normal |
Yeah, I know. The tab titles were about the only thing that updated during the time, although much slower than what your screenshot is showing. |
What laptop are you using? |
Work laptop (MacBook Pro, 2.8 GHz i7, 16GB ram). |
Are you on power? |
* Fix warning deduplication by eval-ing React * Move checkbox to the left * Fix alphabetical sort * Fix the pooling logic * Avoid false positive warning due to controlled/uncontrolled switch * Naming: 15 => Stable, 16 => Next * Prettier * Add "Save" button
This avoids the need to manually patch React locally because of deduplication hiding warnings.
It takes us further from #10587 but I think that:
yarn start
and presses it if we want toBut at least the data generated by this is more accurate than the current version.