Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning deduplication in attribute table #10594

Merged
merged 8 commits into from
Sep 2, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 2, 2017

This avoids the need to manually patch React locally because of deduplication hiding warnings.
It takes us further from #10587 but I think that:

  • We don't want to run headless Chrome as part of every test run anyway
  • We can still add a "Save" button and a script that runs yarn start and presses it if we want to

But at least the data generated by this is more accurate than the current version.

@gaearon gaearon merged commit 3f6e8d2 into facebook:master Sep 2, 2017
@bvaughn
Copy link
Contributor

bvaughn commented Sep 2, 2017

After pulling this branch, the attr test harness totally crushes my Chrome. So bad that I can't even use Chrome's Task Manager to kill tabs. None of my other tabs (eg Messenger) accept text input, etc.

@bvaughn
Copy link
Contributor

bvaughn commented Sep 2, 2017

It actually hung so badly I restarted my computer initially. Then as soon as I tried re-opening Chrome- (because of the service workers)- it auto-started and did the same thing. Took me a few minutes of trying to close the tab before it finally closed, then everything was back to normal

@gaearon
Copy link
Collaborator Author

gaearon commented Sep 2, 2017

Weird, it works consistently for me. Note it’s supposed to take about a minute — you can see the progress in Chrome title bar.

@bvaughn
Copy link
Contributor

bvaughn commented Sep 2, 2017

Yeah, I know. The tab titles were about the only thing that updated during the time, although much slower than what your screenshot is showing.

@gaearon gaearon deleted the attr-table branch September 2, 2017 01:46
@gaearon
Copy link
Collaborator Author

gaearon commented Sep 2, 2017

What laptop are you using?

@bvaughn
Copy link
Contributor

bvaughn commented Sep 2, 2017

Work laptop (MacBook Pro, 2.8 GHz i7, 16GB ram).

@gaearon
Copy link
Collaborator Author

gaearon commented Sep 2, 2017

Are you on power?

flarnie pushed a commit to flarnie/react that referenced this pull request Sep 8, 2017
* Fix warning deduplication by eval-ing React

* Move checkbox to the left

* Fix alphabetical sort

* Fix the pooling logic

* Avoid false positive warning due to controlled/uncontrolled switch

* Naming: 15 => Stable, 16 => Next

* Prettier

* Add "Save" button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants