Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing guard for double-require invariant #4343

Closed
Schoonology opened this issue Jul 10, 2015 · 2 comments
Closed

Missing guard for double-require invariant #4343

Schoonology opened this issue Jul 10, 2015 · 2 comments

Comments

@Schoonology
Copy link

TL;DR: I propose we create a simple guard around doubly-including React, which can cause issues if different blocks work with different instances of React.

I understand this invariant isn't going to matter to everyone, but I've at two points in so many weeks fixed a bug on a co-worker's project because they were accidentally including React twice in the browser: one from a Browserify bundle, and once from a standalone <script>.

@jimfb
Copy link
Contributor

jimfb commented Jul 10, 2015

Duplicate of #2402

TLDR: It's more complicated than you might think, but something we want to do eventually.

@jimfb jimfb closed this as completed Jul 10, 2015
@Schoonology
Copy link
Author

Thanks. Sorry for the dupe, I promise I searched as much as I could think
of first.

On Fri, Jul 10, 2015 at 3:02 PM, Jim [email protected] wrote:

Closed #4343 #4343.


Reply to this email directly or view it on GitHub
#4343 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants