Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools Bug] Cannot remove node "226752" because no matching node was found in the Store. #26793

Closed
jayavel-testsigma opened this issue May 8, 2023 · 12 comments · Fixed by #27147
Closed

[DevTools Bug] Cannot remove node "226752" because no matching node was found in the Store. #26793

jayavel-testsigma opened this issue May 8, 2023 · 12 comments · Fixed by #27147
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug

Comments

@jayavel-testsigma
Copy link

Website or app

https://travel.testsigma.com/

Repro steps

https://travel.testsigma.com/

How often does this bug happen?

Every time

DevTools package (automated)

react-devtools-extensions

DevTools version (automated)

4.27.6-7f8c501f6

Error message (automated)

Cannot remove node "226752" because no matching node was found in the Store.

Error call stack (automated)

at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:28710:43
    at bridge_Bridge.emit (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:26606:22)
    at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:26775:14
    at listener (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:57029:39)

Error component stack (automated)

No response

GitHub query string (automated)

https://api.github.com/search/issues?q=Cannot remove node  because no matching node was found in the Store. in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
@jayavel-testsigma jayavel-testsigma added Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug labels May 8, 2023
@YardWill
Copy link

YardWill commented May 8, 2023

Same to me. Both in Edge Version 4.27.7 (5/7/2023) and Chrome 4.27.6 (4/20/2023)

@YardWill
Copy link

YardWill commented May 9, 2023

It seems that the issue was caused by this PR(#26615). I reverted the version back to 4.27.5 and it worked.

@pitter2416
Copy link

I also encountered the same problem, did you solve it? https://www.ectcm.com

@YardWill
Copy link

YardWill commented May 9, 2023

revert extensions version to 4.27.5

@jrbartola
Copy link

Also seeing this problem- the extension is unusable now. Reverting it seems like more effort than it's worth :/

@Mesoptier Mesoptier mentioned this issue May 9, 2023
Closed
@haniffaraz
Copy link

haniffaraz commented May 10, 2023 •
edited
Loading

Also came across this issue and had to remove the 4.27.6 version and then added 4.27.7 version, the latest. This seems to have fixed the related issues at least in chrome.

@literalpie
Copy link

literalpie commented May 11, 2023 •
edited
Loading

I'm seeing this in 4.27.7. It seems to get triggered every time I wrap a component in React.memo(). To clear the error I have to kill my webpack dev server and restart Chrome.

@hoxyq hoxyq mentioned this issue May 17, 2023
Merged
hoxyq added a commit that referenced this issue May 17, 2023
@hoxyq
React DevTools 4.27.7 -> 4.27.8 (#26823)
2468a87 
Closes #26787,
#26793

Includes these changes:
* fix[devtools]: fixed duplicated backend activation with multiple
renderers ([hoxyq](https://github.com/hoxyq) in
[#26807](#26807))
@hoxyq
Copy link
Contributor

hoxyq commented May 22, 2023

Hey, can anyone try to reproduce this with version 4.27.8 installed?

@literalpie
Copy link

I did some profiling in react dev tools with 4.27.8 today, and did not have any issues.

I wouldn't take this as 100% confirmation that the issue is fixed though, since I wasn't able to reproduce the issue consistently before (my previous comment was premature/wrong).

@hoxyq
Copy link
Contributor

hoxyq commented May 22, 2023

I did some profiling in react dev tools with 4.27.8 today, and did not have any issues.

I wouldn't take this as 100% confirmation that the issue is fixed though, since I wasn't able to reproduce the issue consistently before (my previous comment was premature/wrong).

Sure, thanks for checking.

Currently working on stabilizing the extension behaviour. Keeping this issue open, as this problem is hardly reproducible, would be nice if someone can come up with a reproducible example.

@uaeio
Copy link

uaeio commented May 24, 2023

I have such error when reloading page during profile:

Uncaught Error: Cannot remove node "370" because no matching node was found in the Store.

@Suvikr23
Copy link

Suvikr23 commented Jun 7, 2023

Faced this exact same error while profiling:

Uncaught Error: Cannot remove node "3755" because no matching node was found in the Store.

@hoxyq hoxyq mentioned this issue Jul 25, 2023
Merged
hoxyq added a commit that referenced this issue Aug 3, 2023
@hoxyq
fix[devtools/updateFiberRecursively]: mount suspense fallback set in …
997f52f 
…timed out case (#27147)

Fixes #26793.

I have received a constantly reproducible example of the error, that is
mentioned in the issue above.
When starting `Reload and Profile` in DevTools, React reports an unmount
of a functional component inside Suspense's fallback via
[`onCommitFiberUnmount`](https://github.com/facebook/react/blob/3ff846d106de9273f59d1e4457793a5fcf625aef/packages/react-devtools-shared/src/hook.js#L408-L413)
in
[`commitDeletionEffectsOnFiber`](https://github.com/facebook/react/blob/main/packages/react-reconciler/src/ReactFiberCommitWork.js#L2025),
but this fiber was never registered as mounted in DevTools.

While debugging, I've noticed that in timed-out case for Suspense trees
we only check if both previous fallback child set and next fiber
fallback child set are non-null, but in these recursive calls there is
also a case when previous fallback child set is null and next set is
non-null, so we were skipping the branch.

<img width="1746" alt="Screenshot 2023-07-25 at 15 26 07"
src="https://github.com/facebook/react/assets/28902667/da21a682-9973-43ec-9653-254ba98a0a3f">

After these changes, the issue is no longer reproducible, but I am not
sure if this is the right solution, since I don't know if this case is
correct from reconciler perspective.
EdisonVan pushed a commit to EdisonVan/react that referenced this issue Apr 15, 2024
@hoxyq @AndyPengc12
React DevTools 4.27.7 -> 4.27.8 (facebook#26823)
ba39c0f 
Closes facebook#26787,
facebook#26793

Includes these changes:
* fix[devtools]: fixed duplicated backend activation with multiple
renderers ([hoxyq](https://github.com/hoxyq) in
[facebook#26807](facebook#26807))
EdisonVan pushed a commit to EdisonVan/react that referenced this issue Apr 15, 2024
@hoxyq @AndyPengc12
fix[devtools/updateFiberRecursively]: mount suspense fallback set in …
d8b20a9 
…timed out case (facebook#27147)

Fixes facebook#26793.

I have received a constantly reproducible example of the error, that is
mentioned in the issue above.
When starting `Reload and Profile` in DevTools, React reports an unmount
of a functional component inside Suspense's fallback via
[`onCommitFiberUnmount`](https://github.com/facebook/react/blob/3ff846d106de9273f59d1e4457793a5fcf625aef/packages/react-devtools-shared/src/hook.js#L408-L413)
in
[`commitDeletionEffectsOnFiber`](https://github.com/facebook/react/blob/main/packages/react-reconciler/src/ReactFiberCommitWork.js#L2025),
but this fiber was never registered as mounted in DevTools.

While debugging, I've noticed that in timed-out case for Suspense trees
we only check if both previous fallback child set and next fiber
fallback child set are non-null, but in these recursive calls there is
also a case when previous fallback child set is null and next set is
non-null, so we were skipping the branch.

<img width="1746" alt="Screenshot 2023-07-25 at 15 26 07"
src="https://github.com/facebook/react/assets/28902667/da21a682-9973-43ec-9653-254ba98a0a3f">

After these changes, the issue is no longer reproducible, but I am not
sure if this is the right solution, since I don't know if this case is
correct from reconciler perspective.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix[devtools/updateFiberRecursively]: mount suspense fallback set in timed out case hoxyq/react
9 participants
@jrbartola @YardWill @Suvikr23 @literalpie @hoxyq @haniffaraz @jayavel-testsigma @uaeio @pitter2416