Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming getComponentName to getComponentNameFromType in the error log #21446

Closed
ohmyhusky opened this issue May 6, 2021 · 2 comments
Closed

Comments

@ohmyhusky
Copy link

'Received an unexpected object in getComponentName(). ' +

A very small thing, would it be better to change the getComponentName to getComponentNameFromType in the error log since we separated the original logic into two functions (getComponentNameFromType, getComponentNameFromFiber)? Although it wouldn't be an issue for the authors, it feels like it would be better to sync it with the function name? Would you mind renaming it in the next 'typo fixing'?

faebzz added a commit to faebzz/react that referenced this issue May 6, 2021
@bvaughn
Copy link
Contributor

bvaughn commented May 7, 2021

#21449

@bvaughn bvaughn closed this as completed May 7, 2021
@ohmyhusky
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants