Skip to content

Commit

Permalink
[flags] remove enableDeferRootSchedulingToMicrotask (#32008)
Browse files Browse the repository at this point in the history
Wait for me to merge, but this has landed everywhere and is ready to
remove.

DiffTrain build for [379089d](379089d)
  • Loading branch information
rickhanlonii committed Jan 8, 2025
1 parent 8affad1 commit d46b089
Show file tree
Hide file tree
Showing 34 changed files with 86 additions and 158 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
defffdbba43f89b95d9f67a4fb0fa146c1211734
e30c6693e4c7f2aec25b07f5df69a87163dbee81
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
defffdbba43f89b95d9f67a4fb0fa146c1211734
e30c6693e4c7f2aec25b07f5df69a87163dbee81
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -1942,7 +1942,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.1.0-www-classic-defffdbb-20250106";
exports.version = "19.1.0-www-classic-379089d2-20250108";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1942,7 +1942,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.1.0-www-modern-defffdbb-20250106";
exports.version = "19.1.0-www-modern-379089d2-20250108";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-classic-defffdbb-20250106";
exports.version = "19.1.0-www-classic-379089d2-20250108";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-modern-defffdbb-20250106";
exports.version = "19.1.0-www-modern-379089d2-20250108";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-classic-defffdbb-20250106";
exports.version = "19.1.0-www-classic-379089d2-20250108";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-modern-defffdbb-20250106";
exports.version = "19.1.0-www-modern-379089d2-20250108";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 3 additions & 7 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -2257,8 +2257,6 @@ __DEV__ &&
((didScheduleMicrotask_act = !0), scheduleImmediateRootScheduleTask())
: didScheduleMicrotask ||
((didScheduleMicrotask = !0), scheduleImmediateRootScheduleTask());
enableDeferRootSchedulingToMicrotask ||
scheduleTaskForRootDuringMicrotask(root, now$1());
}
function flushSyncWorkAcrossRoots_impl(syncTransitionLanes, onlyLegacy) {
if (!isFlushingWork && mightHavePendingSyncWork) {
Expand Down Expand Up @@ -14677,8 +14675,6 @@ __DEV__ &&
dynamicFeatureFlags.disableLegacyContextForFunctionComponents,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableDeferRootSchedulingToMicrotask =
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
enableDO_NOT_USE_disableStrictPassiveEffect =
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
enableHiddenSubtreeInsertionEffectCleanup =
Expand Down Expand Up @@ -16946,10 +16942,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-classic-defffdbb-20250106",
version: "19.1.0-www-classic-379089d2-20250108",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-defffdbb-20250106"
reconcilerVersion: "19.1.0-www-classic-379089d2-20250108"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16983,7 +16979,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-classic-defffdbb-20250106";
exports.version = "19.1.0-www-classic-379089d2-20250108";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 3 additions & 7 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -2149,8 +2149,6 @@ __DEV__ &&
((didScheduleMicrotask_act = !0), scheduleImmediateRootScheduleTask())
: didScheduleMicrotask ||
((didScheduleMicrotask = !0), scheduleImmediateRootScheduleTask());
enableDeferRootSchedulingToMicrotask ||
scheduleTaskForRootDuringMicrotask(root, now$1());
}
function flushSyncWorkAcrossRoots_impl(syncTransitionLanes, onlyLegacy) {
if (!isFlushingWork && mightHavePendingSyncWork) {
Expand Down Expand Up @@ -14434,8 +14432,6 @@ __DEV__ &&
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableDeferRootSchedulingToMicrotask =
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
enableDO_NOT_USE_disableStrictPassiveEffect =
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
enableHiddenSubtreeInsertionEffectCleanup =
Expand Down Expand Up @@ -16709,10 +16705,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-modern-defffdbb-20250106",
version: "19.1.0-www-modern-379089d2-20250108",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-defffdbb-20250106"
reconcilerVersion: "19.1.0-www-modern-379089d2-20250108"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16746,7 +16742,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-modern-defffdbb-20250106";
exports.version = "19.1.0-www-modern-379089d2-20250108";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 3 additions & 7 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
dynamicFeatureFlags.disableLegacyContextForFunctionComponents,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableDeferRootSchedulingToMicrotask =
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
enableDO_NOT_USE_disableStrictPassiveEffect =
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
enableHiddenSubtreeInsertionEffectCleanup =
Expand Down Expand Up @@ -1337,8 +1335,6 @@ function ensureRootIsScheduled(root) {
didScheduleMicrotask ||
((didScheduleMicrotask = !0),
scheduleCallback$3(ImmediatePriority, processRootScheduleInImmediateTask));
enableDeferRootSchedulingToMicrotask ||
scheduleTaskForRootDuringMicrotask(root, now());
}
function flushSyncWorkAcrossRoots_impl(syncTransitionLanes, onlyLegacy) {
if (!isFlushingWork && mightHavePendingSyncWork) {
Expand Down Expand Up @@ -10831,10 +10827,10 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1510 = {
bundleType: 0,
version: "19.1.0-www-classic-defffdbb-20250106",
version: "19.1.0-www-classic-379089d2-20250108",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-defffdbb-20250106"
reconcilerVersion: "19.1.0-www-classic-379089d2-20250108"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1511 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10860,4 +10856,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-classic-defffdbb-20250106";
exports.version = "19.1.0-www-classic-379089d2-20250108";
10 changes: 3 additions & 7 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableDeferRootSchedulingToMicrotask =
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
enableDO_NOT_USE_disableStrictPassiveEffect =
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
enableHiddenSubtreeInsertionEffectCleanup =
Expand Down Expand Up @@ -1184,8 +1182,6 @@ function ensureRootIsScheduled(root) {
didScheduleMicrotask ||
((didScheduleMicrotask = !0),
scheduleCallback$3(ImmediatePriority, processRootScheduleInImmediateTask));
enableDeferRootSchedulingToMicrotask ||
scheduleTaskForRootDuringMicrotask(root, now());
}
function flushSyncWorkAcrossRoots_impl(syncTransitionLanes, onlyLegacy) {
if (!isFlushingWork && mightHavePendingSyncWork) {
Expand Down Expand Up @@ -10547,10 +10543,10 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1489 = {
bundleType: 0,
version: "19.1.0-www-modern-defffdbb-20250106",
version: "19.1.0-www-modern-379089d2-20250108",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-defffdbb-20250106"
reconcilerVersion: "19.1.0-www-modern-379089d2-20250108"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1490 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10576,4 +10572,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-modern-defffdbb-20250106";
exports.version = "19.1.0-www-modern-379089d2-20250108";
14 changes: 5 additions & 9 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -4082,8 +4082,6 @@ __DEV__ &&
((didScheduleMicrotask_act = !0), scheduleImmediateRootScheduleTask())
: didScheduleMicrotask ||
((didScheduleMicrotask = !0), scheduleImmediateRootScheduleTask());
enableDeferRootSchedulingToMicrotask ||
scheduleTaskForRootDuringMicrotask(root, now$1());
}
function flushSyncWorkAcrossRoots_impl(syncTransitionLanes, onlyLegacy) {
if (!isFlushingWork && mightHavePendingSyncWork) {
Expand Down Expand Up @@ -23615,8 +23613,6 @@ __DEV__ &&
dynamicFeatureFlags.disableLegacyContextForFunctionComponents,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableDeferRootSchedulingToMicrotask =
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
enableDO_NOT_USE_disableStrictPassiveEffect =
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
enableHiddenSubtreeInsertionEffectCleanup =
Expand Down Expand Up @@ -27417,11 +27413,11 @@ __DEV__ &&
return_targetInst = null;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.1.0-www-classic-defffdbb-20250106" !== isomorphicReactPackageVersion)
if ("19.1.0-www-classic-379089d2-20250108" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.1.0-www-classic-defffdbb-20250106\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.1.0-www-classic-379089d2-20250108\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -27464,10 +27460,10 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-classic-defffdbb-20250106",
version: "19.1.0-www-classic-379089d2-20250108",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-defffdbb-20250106"
reconcilerVersion: "19.1.0-www-classic-379089d2-20250108"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -28065,7 +28061,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.1.0-www-classic-defffdbb-20250106";
exports.version = "19.1.0-www-classic-379089d2-20250108";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
14 changes: 5 additions & 9 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -3969,8 +3969,6 @@ __DEV__ &&
((didScheduleMicrotask_act = !0), scheduleImmediateRootScheduleTask())
: didScheduleMicrotask ||
((didScheduleMicrotask = !0), scheduleImmediateRootScheduleTask());
enableDeferRootSchedulingToMicrotask ||
scheduleTaskForRootDuringMicrotask(root, now$1());
}
function flushSyncWorkAcrossRoots_impl(syncTransitionLanes, onlyLegacy) {
if (!isFlushingWork && mightHavePendingSyncWork) {
Expand Down Expand Up @@ -23400,8 +23398,6 @@ __DEV__ &&
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableDeferRootSchedulingToMicrotask =
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
enableDO_NOT_USE_disableStrictPassiveEffect =
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
enableHiddenSubtreeInsertionEffectCleanup =
Expand Down Expand Up @@ -27196,11 +27192,11 @@ __DEV__ &&
return_targetInst = null;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.1.0-www-modern-defffdbb-20250106" !== isomorphicReactPackageVersion)
if ("19.1.0-www-modern-379089d2-20250108" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.1.0-www-modern-defffdbb-20250106\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.1.0-www-modern-379089d2-20250108\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -27243,10 +27239,10 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-modern-defffdbb-20250106",
version: "19.1.0-www-modern-379089d2-20250108",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-defffdbb-20250106"
reconcilerVersion: "19.1.0-www-modern-379089d2-20250108"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -27844,7 +27840,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.1.0-www-modern-defffdbb-20250106";
exports.version = "19.1.0-www-modern-379089d2-20250108";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
14 changes: 5 additions & 9 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
dynamicFeatureFlags.disableLegacyContextForFunctionComponents,
disableSchedulerTimeoutInWorkLoop =
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
enableDeferRootSchedulingToMicrotask =
dynamicFeatureFlags.enableDeferRootSchedulingToMicrotask,
enableDO_NOT_USE_disableStrictPassiveEffect =
dynamicFeatureFlags.enableDO_NOT_USE_disableStrictPassiveEffect,
enableHiddenSubtreeInsertionEffectCleanup =
Expand Down Expand Up @@ -2131,8 +2129,6 @@ function ensureRootIsScheduled(root) {
mightHavePendingSyncWork = !0;
didScheduleMicrotask ||
((didScheduleMicrotask = !0), scheduleImmediateRootScheduleTask());
enableDeferRootSchedulingToMicrotask ||
scheduleTaskForRootDuringMicrotask(root, now());
}
function flushSyncWorkAcrossRoots_impl(syncTransitionLanes, onlyLegacy) {
if (!isFlushingWork && mightHavePendingSyncWork) {
Expand Down Expand Up @@ -17296,14 +17292,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1781 = React.version;
if (
"19.1.0-www-classic-defffdbb-20250106" !==
"19.1.0-www-classic-379089d2-20250108" !==
isomorphicReactPackageVersion$jscomp$inline_1781
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1781,
"19.1.0-www-classic-defffdbb-20250106"
"19.1.0-www-classic-379089d2-20250108"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17321,10 +17317,10 @@ Internals.Events = [
];
var internals$jscomp$inline_2316 = {
bundleType: 0,
version: "19.1.0-www-classic-defffdbb-20250106",
version: "19.1.0-www-classic-379089d2-20250108",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-defffdbb-20250106"
reconcilerVersion: "19.1.0-www-classic-379089d2-20250108"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2317 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17688,4 +17684,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.1.0-www-classic-defffdbb-20250106";
exports.version = "19.1.0-www-classic-379089d2-20250108";
Loading

0 comments on commit d46b089

Please sign in to comment.