Skip to content

Commit

Permalink
[Fizz][Float] Do not write after closing the stream (#27541)
Browse files Browse the repository at this point in the history
Float methods can hang on to a reference to a Request after the request
is closed due to AsyncLocalStorage. If a Float method is called at this
point we do not want to attempt to flush anything. This change updates
the closing logic to also call `stopFlowing` which will ensure that any
checks against the destination properly reflect that we cannot do any
writes. In addition it updates the enqueueFlush logic to existence check
the destination inside the work function since it can change across the
work scheduling gap if it is async.

fixes: #27540

DiffTrain build for commit 601e5c3.
  • Loading branch information
gnoff committed Oct 18, 2023
1 parent f7bb410 commit cd4934f
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24878,7 +24878,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-canary-20c91b653-20231018";
var ReactVersion = "18.3.0-canary-601e5c385-20231018";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9022,7 +9022,7 @@ var devToolsConfig$jscomp$inline_1031 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-20c91b653-20231018",
version: "18.3.0-canary-601e5c385-20231018",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1224 = {
Expand Down Expand Up @@ -9053,7 +9053,7 @@ var internals$jscomp$inline_1224 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-20c91b653-20231018"
reconcilerVersion: "18.3.0-canary-601e5c385-20231018"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1225 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9448,7 +9448,7 @@ var devToolsConfig$jscomp$inline_1073 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-20c91b653-20231018",
version: "18.3.0-canary-601e5c385-20231018",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1265 = {
Expand Down Expand Up @@ -9479,7 +9479,7 @@ var internals$jscomp$inline_1265 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-20c91b653-20231018"
reconcilerVersion: "18.3.0-canary-601e5c385-20231018"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1266 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-canary-20c91b653-20231018";
var ReactVersion = "18.3.0-canary-601e5c385-20231018";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-20c91b653-20231018";
exports.version = "18.3.0-canary-601e5c385-20231018";
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-20c91b653-20231018";
exports.version = "18.3.0-canary-601e5c385-20231018";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20c91b65341fd404185fc778c6844ac29ab815d5
601e5c38505ebc0ee099d8666b2f7a8b03159ac4

0 comments on commit cd4934f

Please sign in to comment.