Skip to content

Commit

Permalink
Stop syncing ReactTypes to RN (#18366)
Browse files Browse the repository at this point in the history
This is a really old one and all callers have since been codemodded away
anyway because of problems.

This file is not really as rigorously maintained as the official Flow types
but has a few more specifics. However, the inconsistency causes problems
when you try to pass files typed using the built-in Flow typing for React
and mix it with these.

We just happen to get away with it because we compile out the types. If we
didn't we would hit those problems by even using these in our renderers.
  • Loading branch information
sebmarkbage authored Mar 21, 2020
1 parent c5d2fc7 commit b779dd5
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions scripts/rollup/packaging.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,9 @@ async function copyWWWShims() {
}

async function copyRNShims() {
const reactTypesBuildTarget = 'build/react-native/shims/ReactTypes.js';
await Promise.all([
// React Native
asyncCopyTo(`${__dirname}/shims/react-native`, 'build/react-native/shims'),
asyncCopyTo(require.resolve('shared/ReactTypes.js'), reactTypesBuildTarget),
asyncCopyTo(
require.resolve('react-native-renderer/src/ReactNativeTypes.js'),
'build/react-native/shims/ReactNativeTypes.js'
Expand Down

0 comments on commit b779dd5

Please sign in to comment.