Fix test renderer unmount (#8512)

* [react-test-renderer] unmount the inner instances Fixes #8459 * add a test for #8459 * add new test in tests-passing.txt
facebook · Dec 14, 2016 · 931cad5 · 931cad5
1 parent 3def431
commit 931cad5
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/scripts/fiber/tests-passing.txt b/scripts/fiber/tests-passing.txt
@@ -1589,6 +1589,7 @@ src/renderers/testing/__tests__/ReactTestRenderer-test.js
 * warns correctly for refs on SFCs
 * allows an optional createNodeMock function
 * supports unmounting when using refs
+* supports unmounting inner instances
 * supports updates when using refs
 * supports error boundaries
 

diff --git a/src/renderers/testing/ReactTestRenderer.js b/src/renderers/testing/ReactTestRenderer.js
@@ -121,7 +121,10 @@ class ReactTestComponent {
   }
 
   getHostNode(): void {}
-  unmountComponent(): void {}
+  unmountComponent(safely, skipLifecycle): void {
+    // $FlowFixMe https://github.com/facebook/flow/issues/1805
+    this.unmountChildren(safely, skipLifecycle);
+  }
 }
 
 Object.assign(ReactTestComponent.prototype, ReactMultiChild);

diff --git a/src/renderers/testing/__tests__/ReactTestRenderer-test.js b/src/renderers/testing/__tests__/ReactTestRenderer-test.js
@@ -326,6 +326,24 @@ describe('ReactTestRenderer', () => {
     expect(() => inst.unmount()).not.toThrow();
   });
 
+  it('supports unmounting inner instances', () => {
+    let count = 0;
+    class Foo extends React.Component {
+      componentWillUnmount() {
+        count++;
+      }
+      render() {
+        return <div />;
+      }
+    }
+    const inst = ReactTestRenderer.create(
+      <div><Foo /></div>,
+      {createNodeMock: () => 'foo'}
+    );
+    expect(() => inst.unmount()).not.toThrow();
+    expect(count).toEqual(1);
+  });
+
   it('supports updates when using refs', () => {
     const log = [];
     const createNodeMock = element => {