Skip to content

Commit

Permalink
Small flowconfig fixes (#26784)
Browse files Browse the repository at this point in the history
- The whole project root is included by default anyway, the include
section should be redundant and just misleading.
- The generated ignore paths ignore more than intended as they didn't
escape the `.` for regex.

Test Plan:
- wait for CI
- tested the ignore pattern change with renaming files and seeing the
expected files ignored for flow
  • Loading branch information
kassens authored May 8, 2023
1 parent 16d053d commit 7ac5e9a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions scripts/flow/config/flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@

%REACT_RENDERER_FLOW_IGNORES%

[include]
./node_modules/
./packages/
./scripts/

[libs]
./node_modules/fbjs/flow/lib/dev.js
./scripts/flow/environment.js
Expand Down
2 changes: 1 addition & 1 deletion scripts/flow/createFlowConfigs.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function writeConfig(renderer, rendererInfo, isServerSupported) {

if (otherRenderer.shortName !== serverRenderer) {
ignoredPaths.push(
`.*/packages/.*/forks/.*.${otherRenderer.shortName}.js`,
`.*/packages/.*/forks/.*\\.${otherRenderer.shortName}.js`,
);
}
});
Expand Down

0 comments on commit 7ac5e9a

Please sign in to comment.