Fix ReactDOM Flow Types

Now that ReactDOM is Flow type checked we need to fix up its types.
facebook · Feb 24, 2020 · 718be6e · 718be6e
1 parent fde18cf
commit 718be6e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/react-dom/src/client/ReactDOM.js b/packages/react-dom/src/client/ReactDOM.js
@@ -109,19 +109,20 @@ setBatchingImplementation(
 );
 
 export type DOMContainer =
-  | (Element & {_reactRootContainer: ?RootType, ...})
-  | (Document & {_reactRootContainer: ?RootType, ...});
+  | (Element & {_reactRootContainer?: RootType, ...})
+  | (Document & {_reactRootContainer?: RootType, ...});
 
 function createPortal(
   children: ReactNodeList,
   container: DOMContainer,
   key: ?string = null,
-) {
+): React$Portal {
   invariant(
     isValidContainer(container),
     'Target container is not a DOM element.',
   );
   // TODO: pass ReactDOM portal implementation as third argument
+  // $FlowFixMe The Flow type is opaque but there's no way to actually create it.
   return createPortalImpl(children, container, null, key);
 }
 

diff --git a/packages/react-dom/src/client/ReactDOMLegacy.js b/packages/react-dom/src/client/ReactDOMLegacy.js
@@ -370,6 +370,7 @@ export function unmountComponentAtNode(container: DOMContainer) {
     // Unmount should not be batched.
     unbatchedUpdates(() => {
       legacyRenderSubtreeIntoContainer(null, null, container, false, () => {
+        // $FlowFixMe This should probably use `delete container._reactRootContainer`
         container._reactRootContainer = null;
         unmarkContainerAsRoot(container);
       });