Fix assertConsoleErrorDev on message mismatch with withoutStack: true

facebook · May 21, 2024 · 6a01abd · 6a01abd
1 parent 4419f76
commit 6a01abd
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/packages/internal-test-utils/__tests__/ReactInternalTestUtils-test.js b/packages/internal-test-utils/__tests__/ReactInternalTestUtils-test.js
@@ -2427,7 +2427,17 @@ describe('ReactInternalTestUtils console assertions', () => {
             ],
           ]);
         });
-        expect(message).toMatchInlineSnapshot(`"message.replace is not a function"`);
+        expect(message).toMatchInlineSnapshot(`
+          "assertConsoleErrorDev(expected)
+
+          Unexpected error(s) recorded.
+
+          - Expected errors
+          + Received errors
+
+          - Hello
+          + Bye <component stack>"
+        `);
       });
     });
 

diff --git a/packages/internal-test-utils/consoleMock.js b/packages/internal-test-utils/consoleMock.js
@@ -464,7 +464,12 @@ export function createLogAssertion(
       function printDiff() {
         return `${diff(
           expectedMessages
-            .map(message => message.replace('\n', ' '))
+            .map(messageOrTuple => {
+              const message = Array.isArray(messageOrTuple)
+                ? messageOrTuple[0]
+                : messageOrTuple;
+              return message.replace('\n', ' ');
+            })
             .join('\n'),
           receivedLogs.map(message => message.replace('\n', ' ')).join('\n'),
           {