Updated stateless ref warning message with more info

facebook · Sep 25, 2015 · 63cfcca · 63cfcca
1 parent af79118
commit 63cfcca
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/renderers/shared/reconciler/ReactCompositeComponent.js b/src/renderers/shared/reconciler/ReactCompositeComponent.js
@@ -809,7 +809,16 @@ var ReactCompositeComponentMixin = {
     var inst = this.getPublicInstance();
     invariant(inst != null, 'Stateless function components cannot have refs.');
     var publicComponentInstance = component.getPublicInstance();
-    warning(publicComponentInstance != null, 'Stateless function components cannot be given refs.');
+    var componentName = component && component.getName ?
+      component.getName() : 'a component';
+    warning(publicComponentInstance != null,
+      'Stateless function components cannot be given refs ' +
+      '(See ref "%s" in %s created by %s). ' +
+      'Attempts to access this ref will fail.',
+      ref,
+      componentName,
+      this.getName()
+    );
     var refs = inst.refs === emptyObject ? (inst.refs = {}) : inst.refs;
     refs[ref] = publicComponentInstance;
   },

diff --git a/src/renderers/shared/reconciler/__tests__/ReactStatelessComponent-test.js b/src/renderers/shared/reconciler/__tests__/ReactStatelessComponent-test.js
@@ -129,6 +129,7 @@ describe('ReactStatelessComponent', function() {
     spyOn(console, 'error');
 
     var Parent = React.createClass({
+      displayName: 'Parent',
       render: function() {
         return <StatelessComponent name="A" ref="stateless"/>;
       },
@@ -137,7 +138,9 @@ describe('ReactStatelessComponent', function() {
 
     expect(console.error.argsForCall.length).toBe(1);
     expect(console.error.argsForCall[0][0]).toContain(
-      'Stateless function components cannot be given refs.'
+      'Stateless function components cannot be given refs ' +
+      '(See ref "stateless" in StatelessComponent created by Parent). ' +
+      'Attempts to access this ref will fail.'
     );
   });