[DevTools] Remove Welcome dialog (#16834)

facebook · Sep 19, 2019 · 4ddcb8e · 4ddcb8e
1 parent 924a305
commit 4ddcb8e
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 119 deletions.
diff --git a/packages/react-devtools-core/src/standalone.js b/packages/react-devtools-core/src/standalone.js
@@ -40,11 +40,6 @@ let nodeWaitingToConnectHTML: string = '';
 let projectRoots: Array<string> = [];
 let statusListener: StatusListener = (message: string) => {};
 
-// Unlike browser extension users, people using the standalone have actively installed version 4,
-// So we probably don't need to show them a changelog notice.
-// We should give embedded users (e.g. Nuclide, Sonar) a way of showing this dialog though.
-let showWelcomeToTheNewDevToolsDialog: boolean = false;
-
 function setContentDOMNode(value: HTMLElement) {
   node = value;
 
@@ -63,11 +58,6 @@ function setStatusListener(value: StatusListener) {
   return DevtoolsUI;
 }
 
-function setShowWelcomeToTheNewDevToolsDialog(value: boolean) {
-  showWelcomeToTheNewDevToolsDialog = value;
-  return DevtoolsUI;
-}
-
 let bridge: FrontendBridge | null = null;
 let store: Store | null = null;
 let root = null;
@@ -108,7 +98,6 @@ function reload() {
         bridge: ((bridge: any): FrontendBridge),
         canViewElementSourceFunction,
         showTabBar: true,
-        showWelcomeToTheNewDevToolsDialog,
         store: ((store: any): Store),
         warnIfLegacyBackendDetected: true,
         viewElementSourceFunction,
@@ -318,7 +307,6 @@ const DevtoolsUI = {
   connectToSocket,
   setContentDOMNode,
   setProjectRoots,
-  setShowWelcomeToTheNewDevToolsDialog,
   setStatusListener,
   startServer,
 };

diff --git a/packages/react-devtools-extensions/src/main.js b/packages/react-devtools-extensions/src/main.js
@@ -161,7 +161,6 @@ function createPanelIfReactLoaded() {
               overrideTab,
               profilerPortalContainer,
               showTabBar: false,
-              showWelcomeToTheNewDevToolsDialog: true,
               store,
               viewElementSourceFunction,
             }),

diff --git a/packages/react-devtools-shared/src/devtools/views/DevTools.js b/packages/react-devtools-shared/src/devtools/views/DevTools.js
@@ -25,7 +25,6 @@ import {ProfilerContextController} from './Profiler/ProfilerContext';
 import {ModalDialogContextController} from './ModalDialog';
 import ReactLogo from './ReactLogo';
 import WarnIfLegacyBackendDetected from './WarnIfLegacyBackendDetected';
-import ShowWelcomeToTheNewDevToolsDialog from './ShowWelcomeToTheNewDevToolsDialog';
 
 import styles from './DevTools.css';
 
@@ -50,7 +49,6 @@ export type Props = {|
   canViewElementSourceFunction?: ?CanViewElementSource,
   defaultTab?: TabID,
   showTabBar?: boolean,
-  showWelcomeToTheNewDevToolsDialog?: boolean,
   store: Store,
   warnIfLegacyBackendDetected?: boolean,
   viewElementSourceFunction?: ?ViewElementSource,
@@ -92,7 +90,6 @@ export default function DevTools({
   overrideTab,
   profilerPortalContainer,
   showTabBar = false,
-  showWelcomeToTheNewDevToolsDialog = false,
   store,
   warnIfLegacyBackendDetected = false,
   viewElementSourceFunction,
@@ -167,9 +164,6 @@ export default function DevTools({
             </ViewElementSourceContext.Provider>
           </SettingsContextController>
           {warnIfLegacyBackendDetected && <WarnIfLegacyBackendDetected />}
-          {showWelcomeToTheNewDevToolsDialog && (
-            <ShowWelcomeToTheNewDevToolsDialog />
-          )}
         </ModalDialogContextController>
       </StoreContext.Provider>
     </BridgeContext.Provider>

diff --git a/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.css b/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.css
diff --git a/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.js b/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.js
diff --git a/packages/react-devtools-shell/src/devtools.js b/packages/react-devtools-shell/src/devtools.js
@@ -56,7 +56,6 @@ inject('dist/app.js', () => {
         createElement(DevTools, {
           browserTheme: 'light',
           showTabBar: true,
-          showWelcomeToTheNewDevToolsDialog: true,
           warnIfLegacyBackendDetected: true,
         }),
       );