Skip to content

Commit

Permalink
Clean up findFiberByHostInstance from DevTools Hook (#31711)
Browse files Browse the repository at this point in the history
The need for this was removed in
#30831

Since the new DevTools version has been released for a while and we
expect people to more or less auto-update. Future versions of React
don't need this.

Once we remove the remaining uses of `getInstanceFromNode` e.g. in the
deprecated internal `findDOMNode`/`findNodeHandle` and the event system,
we can completely remove the tagging of DOM nodes.
  • Loading branch information
sebmarkbage authored Dec 10, 2024
1 parent 372ec00 commit 3b597c0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions packages/react-reconciler/src/ReactFiberReconciler.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import {enableSchedulingProfiler} from 'shared/ReactFeatureFlags';
import ReactSharedInternals from 'shared/ReactSharedInternals';
import {
getPublicInstance,
getInstanceFromNode,
rendererVersion,
rendererPackageName,
extraDevToolsConfig,
Expand Down Expand Up @@ -847,7 +846,6 @@ export function injectIntoDevTools(): boolean {
version: rendererVersion,
rendererPackageName: rendererPackageName,
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
// Enables DevTools to detect reconciler version rather than renderer version
// which may not match for third party renderers.
reconcilerVersion: ReactVersion,
Expand Down

0 comments on commit 3b597c0

Please sign in to comment.