Log and show error overlay for commit phase errors

facebook · Jun 22, 2021 · 12267f2 · 12267f2
1 parent 568dc35
commit 12267f2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js
@@ -2196,6 +2196,14 @@ export function captureCommitPhaseError(
   nearestMountedAncestor: Fiber | null,
   error: mixed,
 ) {
+  if (__DEV__) {
+    // Commit phase doesn't use invokeGuardedCallback anymore due to perf.
+    // However, we still want to print the message and make it fire onerror.
+    invokeGuardedCallback(null, () => {
+      throw error;
+    });
+  }
+
   if (sourceFiber.tag === HostRoot) {
     // Error was thrown at the root. There is no parent, so the root
     // itself should capture it.

diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.old.js b/packages/react-reconciler/src/ReactFiberWorkLoop.old.js
@@ -2196,6 +2196,14 @@ export function captureCommitPhaseError(
   nearestMountedAncestor: Fiber | null,
   error: mixed,
 ) {
+  if (__DEV__) {
+    // Commit phase doesn't use invokeGuardedCallback anymore due to perf.
+    // However, we still want to print the message and make it fire onerror.
+    invokeGuardedCallback(null, () => {
+      throw error;
+    });
+  }
+
   if (sourceFiber.tag === HostRoot) {
     // Error was thrown at the root. There is no parent, so the root
     // itself should capture it.