-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in image documentation #970
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@@ -62,7 +62,7 @@ var Image = React.createClass({ | |||
/** | |||
* `uri` is a string representing the resource identifier for the image, which | |||
* could be an http address, a local file path, or the name of a static image | |||
* resource (which should be wrapped in the `required('image!name')` function). | |||
* resource (which should be wrapped in the `require('image!name')` function). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, but let's test it internally first. I'd say in a week or so. We should still support using images that are managed by Xcode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahrens - can you give an example of the new relative path hotness?
* Add the "optimizing-flatlist-configuration" topic * Update en.json * Add Props * Add List items tips * Update optimizing-flatlist-configuration.md * Add version 0.60 * Update versions.json * Remove version-0.60 * Create version-0.60-RC-optimizing-flatlist-configuration
No description provided.