Edit Docs Making Offline iOS Bundle #9186
Conversation
|
By analyzing the blame information on this pull request, we identified @hramos and @JoelMarcey to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
| @@ -24,16 +24,10 @@ In Xcode, select your phone as build target and press "Build and run" | |||
|
|
|||
| You have built a great app using React Native, and you are now itching to release it in the App Store. The process is the same as any other native iOS app, with some additional considerations to take into account. | |||
|
|
|||
| ### Disabling the developer menu | |||
| ### Using the offline bundle & Disabling the developer menu | |||
There was a problem hiding this comment.
Do we even need the Using the offline bundle as part of the heading any longer?
There was a problem hiding this comment.
@JoelMarcey I think it could be better title, like Building an app for production. or Building an app for distribution.
Using the offline bundle or Disabling the developer menu is not enough I think.
The Using the offline bundle is the aciton, and Disabling the developer menu is the result. and Building an app for distribution is what people really want to do and can cover all of other things.
Let's see this sentence, Building an app for distribution using the offline bundle, Disabling the developer menu. At least this ordering looks better than other ordering. So the title must be Building an app for distribution or similar things, I think.
what about you?
There was a problem hiding this comment.
@JoelMarcey I'm sorry to have bothered you but could you give me more feedback?
There was a problem hiding this comment.
@skatpgusskat Sorry for the delay. Yes, I like the updated title you proposed. Can you update the PR with that? Then I think we can ship this.
|
@skatpgusskat Thanks! I have one comment. But I think we should be able to land this. |
ghost
added
CLA Signed
Summary: via commit 8c29a52 , the way has changed building offline bundle. So this commit update the docs about that.
|
@skatpgusskat updated the pull request. |
facebook-github-bot
added
the
CLA Signed
|
@JoelMarcey I just remove the subtitle because the above title was In later, I guess It should changed with more detail like the screenshots which let people how to set |
ghost
added
the
CLA Signed
|
Thanks. Sounds reasonable. |
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing.If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
Summary: via commit 8c29a52 , the way has changed building offline bundle. So this commit update the docs about that. Closes facebook#9186 Differential Revision: D3682643 Pulled By: JoelMarcey fbshipit-source-id: 3e4127ca0c00f254dc3464e73c1c2496c0710b85
Summary: via commit 8c29a52 , the way has changed building offline bundle. So this commit update the docs about that. Closes facebook#9186 Differential Revision: D3682643 Pulled By: JoelMarcey fbshipit-source-id: 3e4127ca0c00f254dc3464e73c1c2496c0710b85
via commit 8c29a52 , the way has changed building offline bundle. So this commit update the docs about that.